Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect assume-initial-arn from OCM URL #325

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Jan 27, 2024

What type of PR is this?

feature

What this PR does / Why we need it?

It can still be supplied in the config file as an override, but with this change it is now optional for individuals interacting with standard OCM URLs.

Which Jira/Github issue(s) does this PR fix?

OSD-20606

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

It can still be supplied in the config file as an override, but with
this change it is now optional for individuals interacting with standard
OCM URLs.

Signed-off-by: Michael Shen <mshen@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8f6281c) 45.97% compared to head (43ed1d0) 45.97%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   45.97%   45.97%   -0.01%     
==========================================
  Files          53       53              
  Lines        3754     3772      +18     
==========================================
+ Hits         1726     1734       +8     
- Misses       1754     1764      +10     
  Partials      274      274              
Files Coverage Δ
cmd/ocm-backplane/cloud/common.go 20.11% <42.10%> (+2.72%) ⬆️

Copy link
Contributor

@supreeth7 supreeth7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, supreeth7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6a66f1f into openshift:main Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants