-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect assume-initial-arn from OCM URL #325
Conversation
It can still be supplied in the config file as an override, but with this change it is now optional for individuals interacting with standard OCM URLs. Signed-off-by: Michael Shen <mshen@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 45.97% 45.97% -0.01%
==========================================
Files 53 53
Lines 3754 3772 +18
==========================================
+ Hits 1726 1734 +8
- Misses 1754 1764 +10
Partials 274 274
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjlshen, supreeth7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mjlshen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
feature
What this PR does / Why we need it?
It can still be supplied in the config file as an override, but with this change it is now optional for individuals interacting with standard OCM URLs.
Which Jira/Github issue(s) does this PR fix?
OSD-20606
Pre-checks (if applicable)